Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wait next server is available #505

Merged
merged 2 commits into from
Nov 9, 2024
Merged

feat: wait next server is available #505

merged 2 commits into from
Nov 9, 2024
+22 −4

Conversation

Debbl
Copy link
Contributor

@Debbl Debbl commented Nov 4, 2024

Using get-port-please to wait the renderer process port is available, And set default starterUpDelay is 10_000 ms.

    await waitForPort(rendererPort, { delay: 500, retries: startupDelay / 500 })
      .catch(() => {
        logger.error(`Failed to start renderer process with port ${rendererPort} in ${startupDelay}ms`)
        killWholeProcess()
        process.exit(1)
      })

@saltyshiomix saltyshiomix self-requested a review November 5, 2024 11:52
saltyshiomix
saltyshiomix approved these changes Nov 9, 2024
View reviewed changes
Copy link
Owner

@saltyshiomix saltyshiomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks for your efforts!

lgtm084

@saltyshiomix saltyshiomix merged commit ef8063e into saltyshiomix:main Nov 9, 2024
2 checks passed
@saltyshiomix
Copy link
Owner

@Debbl

Nextron v9.3.0 is out including this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltyshiomix saltyshiomix saltyshiomix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Debbl @saltyshiomix